Repository navigation
https: encode all TLS fields in agent names - #67641
Open
ShogunPanda wants to merge 1 commit into
Open
ShogunPanda wants to merge 1 commit into
ShogunPanda wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
`https.Agent#getName()` joined several TLS options with `:` without encoding them, so a value containing `:` could shift into the next field and produce the same name as a different set of options. A `DataView` passed as `dhparam` was also reduced to its type name. Encode the remaining string, boolean, number, buffer and array valued options, including `sigalgs`, with `getTlsOptionKey()`, which prefixes the type and the length, like the options that were already encoded. Assisted-By: OpenAI GPT-5.6 Sol <openai/gpt-5.6-sol> Signed-off-by: Paolo Insogna <paolo@cowtech.it>
ShogunPanda
force-pushed
the
https-agent-getname-tls-fields
branch
from
November 20, 2026 09:02
579e2b7 to
dde5f87
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67641 +/- ##
==========================================
+ Coverage 90.71% 90.73% +0.01%
==========================================
Files 801 801
Lines 280906 280905 -1
Branches 54246 54249 +3
==========================================
+ Hits 254834 254879 +45
+ Misses 16251 16205 -46
Partials 9821 9821
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https.Agent#getName()joined several TLS options with:without encoding them, so a value containing:could shift into the next field and produce the same name as a different set of options. ADataViewpassed asdhparamwas also reduced to its type name.Encode the remaining string, boolean, number and buffer valued options with
getTlsOptionKey(), which prefixes the type and the length, like the options that were already encoded.Testing: extended
test/parallel/test-https-agent-getname.jsand updatedtest-https-agent-additional-options.js. Theparallel/test-https-*andparallel/test-tls-*suites and eslint pass.