Skip to content

gh-148603: Update docstrings now UTF-8 is default - #162327

Open
Very-cool-guy wants to merge 4 commits into
python:mainfrom
Very-cool-guy:3.15-utf8-docstr
Open

Very-cool-guy wants to merge 4 commits into
python:mainfrom
Very-cool-guy:3.15-utf8-docstr

Conversation

@Very-cool-guy

@Very-cool-guy Very-cool-guy commented Nov 20, 2026 •

Copy link
Copy Markdown

@python-cla-bot

python-cla-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Nov 20, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Nov 20, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@cmaloney

Copy link
Copy Markdown
Contributor

cc: @methane

@cmaloney cmaloney added docs Documentation in the Doc dir skip news labels Nov 21, 2026
@cmaloney cmaloney removed the docs Documentation in the Doc dir label Nov 21, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Nov 21, 2026

@methane methane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made these edits directly on GitHub, so I'm not sure whether the lines are properly wrapped at 80 columns. Please make the same changes to the docstrings in _pyio.

https://github.com/Very-cool-guy/cpython/blob/c4df8beaf2ca970191a8dbbbd34c1cdac3ed9603/Modules/_io/textio.c#L1153-L1157
The same issue exists here too, but I'll leave it up to you whether to fix it in this PR.

Comment thread Modules/_io/_iomodule.c Resolved
Comment thread Modules/_io/_iomodule.c Resolved
Comment thread Modules/_io/_iomodule.c Resolved
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@Very-cool-guy

Copy link
Copy Markdown
Author

uh, are you sure about the changes? it looks weird now.

Clarified the description of file modes and encoding handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants