Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning a dictionary to the C Unpickler's memo populated the old memo and then discarded its array. Copying another unpickler's memo also omitted its sequential index and sparse entries, so continuing a pickle stream could raise UnpicklingError or retrieve stale objects.
Build and validate the replacement memo before installing it, copy the complete state from memo proxies, and install the replacement before releasing the old entries. Include sparse entries in memo snapshots so dictionary-based transfers retain them too. Invalid assignments leave the previous memo intact.
The regression tests cover dictionary and proxy assignments, protocol 4/5 continuation with shared references, sparse indexes, empty and self assignments, rejected keys, independent dictionary copies, and reentrant finalizers.
Fixes #111066.
Validation: