Skip to content

Read bsc's flags into a typed compile request - #9306

Draft
cknitt wants to merge 1 commit into
validate-compiler-flagsfrom
compile-request
Draft

cknitt wants to merge 1 commit into
validate-compiler-flagsfrom
compile-request

Conversation

@cknitt

@cknitt cknitt commented Nov 14, 2026

Copy link
Copy Markdown
Member

Step 2 of #9303. Stacked on #9304.

bsc's flags set global compiler state as they're parsed, so the only way to describe a compile was a list of strings. This PR adds that description as a record, Compile_request.t:

  • of_argv reads flags into the record. A field holds what the flags gave, and repeatable flags (-open, -w, -I, …) keep their order. Values are checked while reading: jsx version, source-map mode, color, genType module and resolution, experimental feature names, package outputs, warning specs.
  • to_argv writes the record back as flags.
  • apply sets the request's compiler state from the record, on top of what is there. This is how @@config flags still apply on top of the command line.
  • Each flag has a kind: Build_system, Public, Debug or Command. of_argv reads all of them; callers that accept only some kinds check them with kind_of. The build system will decide which public flags it warns about, since it knows its own rescript.json fields.

bsc's command line and @@config now go through the record. The flag table moved from the driver to Compile_request. bsc -help prints the same text as before.

The next PR has the build system build the record directly for in-process compiles.

Behaviour differences

All of these are on bsc's command line or in @@config; the build system's builds are unaffected (the full test suites pass):

  • Invalid values are errors: e.g. -color red, -bs-gentype-module amd, -enable-experimental Unknown. Before, some were silently ignored.
  • Commands (-format, -e, -reprint-source, -v) run after all flags are read, not at their position.
  • The namespace of -bs-ns is opened before the -open modules, whatever the order on the command line. The build system already passes -bs-ns first.
  • -bs-ns given twice: the last one is used. Before, both were opened.
  • An invalid @@config flag applies none of the file's flags. Before, the flags up to the bad one were applied. A command in @@config, such as -v, now counts as invalid instead of running.

Tests

  • tests/ounit_tests/ounit_compile_request_tests.ml:
    • every flag is read back from to_argv, one at a time and all at once;
    • repeated flags keep their order;
    • commands and files stay in order;
    • invalid values are rejected;
    • a base request is extended;
    • key flags have the expected kinds.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Kbf3gHAzsdStoCEpBgx2tS

@cknitt
cknitt added this pull request to stack #9307 November 14, 2026 17:00
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Changelog

🏠 Internal

  • Read bsc's flags into a typed request, and reject invalid values such as an unknown experimental feature, color setting or genType module.

Semantic Diff

1 commit · Full page

✏️ Read bsc's flags into a typed compile request

daafede · cknitt + Claude · Nov 14, 2026, 10:11 UTC · edited

Why

bsc's flags set global compiler state as they were parsed, so the only way to describe a compile was a list of strings. Compile_request is that description as a record: of_argv reads the flags into it, to_argv writes them back, and apply sets the request's state from it. bsc's command line and a file's @@config flags go through it now; the build system can build the record directly in a next step (#9303).

Each flag has a kind: Build_system, Public, Debug or Command. The record holds what the flags gave, so @@config is applied on top of the command line as before. A round-trip test reads every flag back from to_argv. Bsc_args keeps only the usage text and its exceptions; its old parser and Ext_spec are removed.

Diagnostic added (invalid flag values)

bsc -color red -enable-experimental Unknown A.res

diagnostic

-(the values were ignored)
+Unsupported color setting: red

Other differences, all on bsc's command line: commands such as -format and -e run after every flag is read, not at their position; the namespace of -bs-ns is opened before the -open modules, as the build system passes it anyway; an invalid @@config flag applies none of the file's flags.

Part of #9303

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

⚠️ Compiler benchmarks

Allocated words

In total: 639,876,044 → 640,436,225 (+0.09%).

Generated projects: 629,809,420 → 627,305,206 (-0.40%).

⚠️ Regression: 138 benchmarks allocate more than 1% more.

🎉 Improvement: 1 benchmark allocates more than 1% less.

Benchmark Base Head Change
packages/@rescript/runtime/Primitive_float_extern.res 93,518 96,771 +3.48%
packages/@rescript/runtime/Stdlib_Blob.res 93,736 96,989 +3.47%
packages/@rescript/runtime/Primitive_list.resi 91,801 94,971 +3.45%
packages/@rescript/runtime/Stdlib_File.res 95,545 98,798 +3.40%
packages/@rescript/runtime/Primitive_promise.res 96,893 100,146 +3.36%
packages/@rescript/runtime/Primitive_int_extern.res 97,746 100,999 +3.33%
packages/@rescript/runtime/Stdlib_Iterable.res 98,775 102,062 +3.33%
packages/@rescript/runtime/Stdlib_AsyncIterable.res 98,846 102,133 +3.33%
packages/@rescript/runtime/Primitive_string_extern.res 98,054 101,307 +3.32%
packages/@rescript/runtime/Obj.res 98,995 102,248 +3.29%
227 more changes
Benchmark Base Head Change
packages/@rescript/runtime/Stdlib_Iterable.resi 98,083 101,253 +3.23%
packages/@rescript/runtime/Stdlib_AsyncIterable.resi 98,232 101,402 +3.23%
packages/@rescript/runtime/Primitive_dict.res 102,553 105,806 +3.17%
packages/@rescript/runtime/Primitive_exceptions.resi 100,233 103,403 +3.16%
packages/@rescript/runtime/RescriptTools.res 104,416 107,669 +3.12%
packages/@rescript/runtime/Primitive_hash.resi 102,658 105,828 +3.09%
packages/@rescript/runtime/Primitive_module.resi 103,096 106,266 +3.07%
packages/@rescript/runtime/Stdlib_ArrayBuffer.res 107,368 110,655 +3.06%
packages/@rescript/runtime/Stdlib_TaggedTemplate.resi 106,038 109,208 +2.99%
packages/@rescript/runtime/RescriptTools_ExtractCodeBlocks.res 111,971 115,224 +2.91%
packages/@rescript/runtime/Stdlib_ArrayBuffer.resi 110,903 114,073 +2.86%
packages/@rescript/runtime/Stdlib_TaggedTemplate.res 115,240 118,527 +2.85%
packages/@rescript/runtime/Primitive_array_extern.res 114,051 117,304 +2.85%
packages/@rescript/runtime/Primitive_object_extern.res 114,560 117,813 +2.84%
packages/@rescript/runtime/Stdlib_Lazy.resi 112,348 115,518 +2.82%
packages/@rescript/runtime/Stdlib_Intl_Segments.res 116,432 119,685 +2.79%
packages/@rescript/runtime/Stdlib_Bool.resi 116,732 119,902 +2.72%
packages/@rescript/runtime/Dom_storage2.res 120,013 123,266 +2.71%
packages/@rescript/runtime/Primitive_object.resi 117,039 120,209 +2.71%
packages/@rescript/runtime/Jsx.res 121,569 124,822 +2.68%
packages/@rescript/runtime/Stdlib_WeakSet.res 123,003 126,256 +2.64%
packages/@rescript/runtime/Primitive_option.resi 122,179 125,349 +2.59%
packages/@rescript/runtime/Stdlib_JsExn.resi 122,689 125,859 +2.58%
build/Namespace/clean 84,216,944 82,151,508 -2.45%
packages/@rescript/runtime/Stdlib_WeakMap.res 135,334 138,587 +2.40%
packages/@rescript/runtime/Stdlib_Type.resi 135,842 139,012 +2.33%
packages/@rescript/runtime/Stdlib_Global.res 141,632 144,919 +2.32%
packages/@rescript/runtime/Stdlib_Temporal_Now.res 143,368 146,621 +2.27%
packages/@rescript/runtime/Stdlib_Bool.res 146,294 149,581 +2.25%
packages/@rescript/runtime/Stdlib_Symbol.res 146,342 149,629 +2.25%
packages/@rescript/runtime/Primitive_bool.res 147,530 150,783 +2.20%
packages/@rescript/runtime/Primitive_float.res 147,571 150,824 +2.20%
packages/@rescript/runtime/Stdlib_Ordering.res 152,756 156,009 +2.13%
packages/@rescript/runtime/Stdlib_IterableIterator.resi 149,327 152,497 +2.12%
packages/@rescript/runtime/Stdlib_Intl_Common.res 154,191 157,444 +2.11%
packages/@rescript/runtime/Stdlib_Intl_Segmenter.res 154,385 157,638 +2.11%
packages/@rescript/runtime/Stdlib_Global.resi 155,462 158,632 +2.04%
packages/@rescript/runtime/Stdlib_Intl_NumberFormat_Grouping.res 159,811 163,064 +2.04%
packages/@rescript/runtime/Primitive_string.res 160,327 163,580 +2.03%
packages/@rescript/runtime/Stdlib_RegExp.res 163,572 166,859 +2.01%
packages/@rescript/runtime/Stdlib_Iterator.resi 159,300 162,470 +1.99%
packages/@rescript/runtime/Stdlib_AsyncIterableIterator.resi 159,839 163,009 +1.98%
packages/@rescript/runtime/Stdlib_Symbol.resi 160,055 163,225 +1.98%
packages/@rescript/runtime/Stdlib_Generator.resi 160,461 163,631 +1.98%
packages/@rescript/runtime/Stdlib_Pair.res 165,890 169,143 +1.96%
packages/@rescript/runtime/Dom_storage.res 167,369 170,622 +1.94%
packages/@rescript/runtime/Stdlib_Intl_ListFormat.res 169,670 172,923 +1.92%
packages/@rescript/runtime/Stdlib_AsyncGenerator.resi 165,839 169,009 +1.91%
packages/@rescript/runtime/Stdlib_JsExn.res 173,528 176,815 +1.89%
packages/@rescript/runtime/Primitive_int.res 172,694 175,947 +1.88%
packages/@rescript/runtime/Stdlib_Intl.res 174,054 177,307 +1.87%
packages/@rescript/belt/src/Belt_Int.resi 149,685 152,467 +1.86%
packages/@rescript/belt/src/Belt_Float.resi 151,165 153,947 +1.84%
packages/@rescript/runtime/Stdlib_IterableIterator.res 178,969 182,256 +1.84%
packages/@rescript/runtime/Primitive_bigint.res 178,166 181,419 +1.83%
packages/@rescript/runtime/Stdlib_Intl_Collator.res 178,512 181,765 +1.82%
packages/@rescript/runtime/Stdlib_Intl_RelativeTimeFormat.res 180,309 183,562 +1.80%
packages/@rescript/runtime/Stdlib_AsyncIterator.resi 177,732 180,902 +1.78%
packages/@rescript/belt/src/Belt_Float.res 165,068 167,967 +1.76%
packages/@rescript/belt/src/Belt_Int.res 165,806 168,705 +1.75%
packages/@rescript/runtime/Stdlib_JsError.resi 184,882 188,052 +1.71%
packages/@rescript/runtime/Stdlib_BigInt.resi 186,497 189,667 +1.70%
packages/@rescript/belt/src/Belt_internalBucketsType.resi 164,638 167,420 +1.69%
packages/@rescript/runtime/Stdlib_RegExp.resi 187,713 190,883 +1.69%
packages/@rescript/runtime/Primitive_array.res 193,362 196,615 +1.68%
packages/@rescript/belt/src/Belt_MutableStack.resi 169,195 171,977 +1.64%
packages/@rescript/runtime/Stdlib_Intl_Locale.res 197,906 201,159 +1.64%
packages/@rescript/belt/src/Belt_SortArrayString.resi 169,491 172,273 +1.64%
packages/@rescript/belt/src/Belt_SortArrayInt.resi 169,609 172,391 +1.64%
packages/@rescript/runtime/Stdlib_Generator.res 200,653 203,940 +1.64%
packages/@rescript/runtime/Stdlib_Float.resi 194,241 197,411 +1.63%
packages/@rescript/runtime/Stdlib_Type.res 201,825 205,112 +1.63%
packages/@rescript/runtime/Primitive_exceptions.res 202,176 205,463 +1.63%
packages/@rescript/runtime/Stdlib_Intl_PluralRules.res 201,734 204,987 +1.61%
packages/@rescript/runtime/Primitive_list.res 205,277 208,564 +1.60%
packages/@rescript/runtime/Stdlib_Map.res 205,588 208,875 +1.60%
packages/@rescript/runtime/Stdlib_Nullable.resi 199,756 202,926 +1.59%
packages/@rescript/runtime/Stdlib_BigInt.res 207,266 210,553 +1.59%
packages/@rescript/belt/src/Belt_HashSetString.resi 175,467 178,249 +1.59%
packages/@rescript/belt/src/Belt_HashSetInt.resi 175,580 178,362 +1.58%
packages/@rescript/belt/src/Belt_Range.resi 176,571 179,353 +1.58%
packages/@rescript/runtime/Stdlib_Set.res 210,937 214,224 +1.56%
packages/@rescript/runtime/Stdlib_AsyncGenerator.res 211,563 214,850 +1.55%
packages/@rescript/runtime/Stdlib_Null.resi 204,429 207,599 +1.55%
packages/@rescript/runtime/Stdlib_Int.resi 206,017 209,187 +1.54%
packages/@rescript/belt/src/Belt.res 188,357 191,222 +1.52%
packages/@rescript/runtime/Stdlib_Float.res 219,276 222,563 +1.50%
packages/@rescript/runtime/Stdlib_Lazy.res 222,117 225,404 +1.48%
packages/@rescript/runtime/Stdlib_Map.resi 217,022 220,192 +1.46%
packages/@rescript/runtime/Stdlib_Temporal.res 224,134 227,387 +1.45%
packages/@rescript/runtime/Stdlib_AsyncIterableIterator.res 228,831 232,118 +1.44%
packages/@rescript/belt/src/Belt_internalSetBuckets.resi 194,164 196,946 +1.43%
packages/@rescript/runtime/Stdlib_DataView.res 230,137 233,424 +1.43%
packages/@rescript/runtime/Stdlib_JsError.res 230,502 233,789 +1.43%
packages/@rescript/runtime/Stdlib_Iterator.res 235,490 238,777 +1.40%
packages/@rescript/runtime/Stdlib_Set.resi 228,874 232,044 +1.39%
packages/@rescript/runtime/Pervasives.res 239,636 242,889 +1.36%
packages/@rescript/runtime/Primitive_js_extern.res 239,948 243,201 +1.36%
packages/@rescript/runtime/Stdlib_IteratorObject.resi 234,297 237,467 +1.35%
packages/@rescript/belt/src/Belt_MutableQueue.resi 207,240 210,022 +1.34%
packages/@rescript/runtime/Stdlib_Option.resi 236,417 239,587 +1.34%
packages/@rescript/runtime/Stdlib_JSON.resi 237,034 240,204 +1.34%
packages/@rescript/runtime/Stdlib_Dict.resi 240,762 243,932 +1.32%
packages/@rescript/runtime/Stdlib_Object.res 247,268 250,521 +1.32%
packages/@rescript/runtime/Stdlib_IteratorObject.res 250,798 254,085 +1.31%
packages/@rescript/belt/src/Belt_HashMapString.resi 213,628 216,410 +1.30%
packages/@rescript/belt/src/Belt_HashMapInt.resi 213,742 216,524 +1.30%
packages/@rescript/belt/src/Belt_HashSet.resi 222,692 225,474 +1.25%
packages/@rescript/belt/src/Belt_internalBuckets.resi 222,956 225,738 +1.25%
packages/@rescript/runtime/Stdlib_Temporal_PlainMonthDay.res 268,658 271,911 +1.21%
packages/@rescript/runtime/Stdlib_DataView.resi 267,958 271,128 +1.18%
packages/@rescript/runtime/RescriptTools_Docgen.resi 273,494 276,664 +1.16%
packages/@rescript/belt/src/Belt_Result.resi 240,078 242,860 +1.16%
packages/@rescript/runtime/RescriptTools_Docgen.res 283,715 287,002 +1.16%
packages/@rescript/belt/src/Belt_Option.resi 243,288 246,070 +1.14%
packages/@rescript/runtime/Stdlib_AsyncIterator.res 295,604 298,891 +1.11%
packages/@rescript/runtime/Stdlib_JSON.res 297,904 301,191 +1.10%
packages/@rescript/runtime/Primitive_option.res 299,193 302,480 +1.10%
packages/@rescript/belt/src/Belt_SortArray.resi 253,856 256,638 +1.10%
packages/@rescript/belt/src/Belt_SetString.resi 259,836 262,618 +1.07%
packages/@rescript/belt/src/Belt_SetInt.resi 259,963 262,745 +1.07%
packages/@rescript/runtime/Stdlib_Result.resi 296,287 299,457 +1.07%
packages/@rescript/belt/src/Belt_Id.resi 260,200 262,982 +1.07%
packages/@rescript/runtime/Stdlib_Temporal_Instant.res 308,018 311,271 +1.06%
packages/@rescript/belt/src/Belt_MutableSetString.resi 264,910 267,692 +1.05%
packages/@rescript/belt/src/Belt_MutableSetInt.resi 265,027 267,809 +1.05%
packages/@rescript/runtime/Stdlib_Dict.res 320,385 323,672 +1.03%
packages/@rescript/runtime/Stdlib_Temporal_PlainTime.res 320,676 323,929 +1.01%
packages/@rescript/runtime/Stdlib_Math.res 328,145 331,432 +1.00%
packages/@rescript/belt/src/Belt_Id.res 290,420 293,319 +1.00%
packages/@rescript/belt/src/Belt_Range.res 290,478 293,377 +1.00%
packages/@rescript/runtime/Stdlib_Nullable.res 331,677 334,964 +0.99%
packages/@rescript/belt/src/Belt_internalBucketsType.res 292,621 295,520 +0.99%
packages/@rescript/runtime/Stdlib_Null.res 334,093 337,380 +0.98%
packages/@rescript/runtime/Primitive_module.res 340,469 343,756 +0.97%
packages/@rescript/runtime/Stdlib_Math.resi 328,609 331,779 +0.96%
packages/@rescript/runtime/Stdlib_Int8Array.res 343,403 346,656 +0.95%
packages/@rescript/runtime/Stdlib_Uint8Array.res 343,416 346,669 +0.95%
packages/@rescript/runtime/Stdlib_Float32Array.res 343,523 346,776 +0.95%
packages/@rescript/runtime/Stdlib_Float64Array.res 343,523 346,776 +0.95%
packages/@rescript/runtime/Stdlib_Int16Array.res 343,548 346,801 +0.95%
packages/@rescript/runtime/Stdlib_Int32Array.res 343,550 346,803 +0.95%
packages/@rescript/runtime/Stdlib_Uint16Array.res 343,555 346,808 +0.95%
packages/@rescript/runtime/Stdlib_Uint32Array.res 343,555 346,808 +0.95%
packages/@rescript/runtime/Stdlib_BigInt64Array.res 343,580 346,833 +0.95%
packages/@rescript/runtime/Stdlib_BigUint64Array.res 343,657 346,910 +0.95%
packages/@rescript/runtime/Stdlib_Uint8ClampedArray.res 343,931 347,184 +0.95%
packages/@rescript/belt/src/Belt_HashMap.resi 296,822 299,604 +0.94%
packages/@rescript/runtime/Stdlib_Promise.res 352,826 356,113 +0.93%
packages/@rescript/runtime/Stdlib_Promise.resi 355,939 359,109 +0.89%
packages/@rescript/runtime/Stdlib_Temporal_Common.res 366,499 369,752 +0.89%
packages/@rescript/runtime/Stdlib_Console.res 370,395 373,682 +0.89%
packages/@rescript/belt/src/Belt_MutableMapString.resi 314,907 317,689 +0.88%
packages/@rescript/belt/src/Belt_MutableMapInt.resi 315,025 317,807 +0.88%
packages/@rescript/runtime/Stdlib_Temporal_Duration.res 374,026 377,279 +0.87%
packages/@rescript/runtime/Stdlib_Temporal_PlainYearMonth.res 382,716 385,969 +0.85%
packages/@rescript/runtime/Stdlib_Intl_DateTimeFormat.res 389,444 392,697 +0.84%
packages/@rescript/runtime/Stdlib_Temporal_PlainDate.res 404,326 407,579 +0.80%
packages/@rescript/runtime/Stdlib_Intl_NumberFormat.res 404,689 407,942 +0.80%
packages/@rescript/belt/src/Belt_internalAVLset.resi 354,783 357,565 +0.78%
packages/@rescript/runtime/Stdlib_List.resi 409,777 412,947 +0.77%
packages/@rescript/runtime/Stdlib_Console.resi 411,909 415,079 +0.77%
packages/@rescript/belt/src/Belt_MutableStack.res 390,405 393,304 +0.74%
packages/@rescript/runtime/Stdlib_Temporal_PlainDateTime.res 438,634 441,887 +0.74%
packages/@rescript/belt/src/Belt_Option.res 391,883 394,782 +0.74%
packages/@rescript/runtime/Stdlib_Int.res 458,001 461,288 +0.72%
packages/@rescript/belt/src/Belt_MapString.resi 391,222 394,004 +0.71%
packages/@rescript/belt/src/Belt_MapInt.resi 391,265 394,047 +0.71%
packages/@rescript/belt/src/Belt_MutableMap.resi 395,358 398,140 +0.70%
packages/@rescript/belt/src/Belt_Result.res 412,200 415,099 +0.70%
packages/@rescript/belt/src/Belt_MutableSet.resi 397,460 400,242 +0.70%
packages/@rescript/belt/src/Belt_SetDict.resi 402,594 405,376 +0.69%
packages/@rescript/runtime/Stdlib_String.res 505,151 508,438 +0.65%
packages/@rescript/runtime/Stdlib_String.resi 497,419 500,589 +0.64%
packages/@rescript/belt/src/Belt_Set.resi 437,352 440,134 +0.64%
packages/@rescript/belt/src/Belt_internalAVLtree.resi 452,337 455,119 +0.62%
packages/@rescript/runtime/Stdlib_Date.res 551,945 555,232 +0.60%
packages/@rescript/runtime/Stdlib_Temporal_ZonedDateTime.res 574,641 577,894 +0.57%
packages/@rescript/belt/src/Belt_MapDict.resi 513,212 515,994 +0.54%
packages/@rescript/runtime/Stdlib_Date.resi 614,211 617,381 +0.52%
packages/@rescript/belt/src/Belt_Map.resi 579,385 582,185 +0.48%
packages/@rescript/runtime/Stdlib_Array.resi 728,548 731,718 +0.44%
packages/@rescript/runtime/Stdlib_Option.res 762,258 765,543 +0.43%
packages/@rescript/belt/src/Belt_Array.resi 650,246 653,028 +0.43%
packages/@rescript/belt/src/Belt_internalSetBuckets.res 704,425 707,396 +0.42%
packages/@rescript/runtime/Stdlib_TypedArray.res 785,231 788,484 +0.41%
packages/@rescript/belt/src/Belt_internalSetInt.res 737,597 740,462 +0.39%
packages/@rescript/belt/src/Belt_internalSetString.res 738,788 741,653 +0.39%
packages/@rescript/belt/src/Belt_List.resi 758,658 761,440 +0.37%
packages/@rescript/belt/src/Belt_MutableQueue.res 799,497 802,394 +0.36%
packages/@rescript/belt/src/Belt_HashSetInt.res 858,010 860,911 +0.34%
packages/@rescript/belt/src/Belt_HashSetString.res 858,327 861,226 +0.34%
packages/@rescript/runtime/Primitive_hash.res 974,400 977,687 +0.34%
packages/@rescript/belt/src/Belt_Set.res 865,401 868,298 +0.33%
packages/@rescript/runtime/Stdlib.res 982,667 985,920 +0.33%
packages/@rescript/runtime/Dom.res 1,071,613 1,074,866 +0.30%
packages/@rescript/belt/src/Belt_internalBuckets.res 975,308 978,207 +0.30%
packages/@rescript/runtime/JsxEvent.res 1,091,825 1,095,051 +0.30%
packages/@rescript/belt/src/Belt_HashSet.res 986,522 989,421 +0.29%
packages/@rescript/belt/src/Belt_Map.res 989,277 992,178 +0.29%
packages/@rescript/runtime/Primitive_object.res 1,170,234 1,173,517 +0.28%
packages/@rescript/belt/src/Belt_HashMapInt.res 1,070,365 1,073,264 +0.27%
packages/@rescript/belt/src/Belt_HashMapString.res 1,071,077 1,073,976 +0.27%
packages/@rescript/runtime/Stdlib_Result.res 1,279,779 1,283,066 +0.26%
packages/@rescript/runtime/Stdlib_Array.res 1,291,788 1,295,075 +0.25%
packages/@rescript/belt/src/Belt_MutableMapString.res 1,164,926 1,167,829 +0.25%
packages/@rescript/belt/src/Belt_MutableMapInt.res 1,164,649 1,167,548 +0.25%
packages/@rescript/belt/src/Belt_MapInt.res 1,190,580 1,193,479 +0.24%
packages/@rescript/belt/src/Belt_MapString.res 1,191,116 1,194,015 +0.24%
packages/@rescript/belt/src/Belt_HashMap.res 1,210,726 1,213,623 +0.24%
packages/@rescript/belt/src/Belt_SetInt.res 1,301,875 1,304,778 +0.22%
packages/@rescript/belt/src/Belt_MutableMap.res 1,314,131 1,317,057 +0.22%
packages/@rescript/belt/src/Belt_SetString.res 1,302,606 1,305,503 +0.22%
packages/@rescript/belt/src/Belt_SortArrayString.res 1,361,826 1,364,731 +0.21%
packages/@rescript/belt/src/Belt_SortArrayInt.res 1,360,036 1,362,933 +0.21%
packages/@rescript/belt/src/Belt_SetDict.res 1,459,153 1,462,050 +0.20%
packages/@rescript/belt/src/Belt_SortArray.res 1,466,749 1,469,648 +0.20%
packages/@rescript/belt/src/Belt_MapDict.res 1,645,238 1,648,151 +0.18%
packages/@rescript/belt/src/Belt_MutableSetInt.res 1,683,085 1,685,985 +0.17%
packages/@rescript/belt/src/Belt_MutableSetString.res 1,684,331 1,687,228 +0.17%
packages/@rescript/runtime/JsxDOMStyle.res 1,935,330 1,938,583 +0.17%
packages/@rescript/belt/src/Belt_MutableSet.res 1,923,153 1,926,050 +0.15%
packages/@rescript/belt/src/Belt_Array.res 2,182,604 2,185,503 +0.13%
parse/RedBlackTreeNoComments.res 355,092 355,530 +0.12%
packages/@rescript/runtime/JsxDOM.res 2,663,572 2,666,825 +0.12%
parse/RedBlackTree.res 362,805 363,243 +0.12%
build/WideDeps/clean 371,586,824 371,206,993 -0.10%

Instructions

In total: 9,215,515,257 → 9,216,812,351 (+0.01%).

Benchmark Base Head Change
packages/@rescript/runtime/Stdlib_Math.resi 21,554,837 21,598,335 +0.20%
packages/@rescript/belt/src/Belt_List.resi 39,228,937 39,299,024 +0.18%
packages/@rescript/runtime/JsxDOMStyle.res 95,313,186 95,474,736 +0.17%
packages/@rescript/runtime/Stdlib_Temporal_PlainDateTime.res 25,774,467 25,818,133 +0.17%
packages/@rescript/runtime/Stdlib_Temporal_PlainDate.res 24,327,364 24,368,547 +0.17%
packages/@rescript/runtime/Stdlib_List.resi 24,779,016 24,820,547 +0.17%
packages/@rescript/belt/src/Belt_Array.resi 33,964,722 34,014,381 +0.15%
packages/@rescript/runtime/Stdlib_Temporal_ZonedDateTime.res 31,457,541 31,501,950 +0.14%
packages/@rescript/runtime/Stdlib_Date.resi 34,538,978 34,586,101 +0.14%
packages/@rescript/runtime/Stdlib_String.resi 29,708,487 29,745,219 +0.12%
1 more change
Benchmark Base Head Change
packages/@rescript/runtime/JsxDOM.res 117,362,979 117,482,677 +0.10%

Output size

In total: 25,920,835 → 25,920,834 (±0.00%).

None of the 13 benchmarks changed by 0.1% or more.

Pull request daafede compared with base 89b6f31 in this run.

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.61905% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.26%. Comparing base (4e7b646) to head (daafede).

Files with missing lines Patch % Lines
compiler/bsc/compile_request.ml 94.17% 24 Missing ⚠️
compiler/bsc/rescript_compiler_driver.ml 64.51% 11 Missing ⚠️
compiler/core/js_packages_info.ml 70.58% 5 Missing ⚠️
tests/ounit_tests/ounit_compile_request_tests.ml 93.44% 4 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           validate-compiler-flags    #9306      +/-   ##
===========================================================
+ Coverage                    82.17%   82.26%   +0.09%     
===========================================================
  Files                          458      459       +1     
  Lines                        65690    66033     +343     
===========================================================
+ Hits                         53978    54320     +342     
- Misses                       11712    11713       +1     
Files with missing lines Coverage Δ
compiler/common/js_config.ml 88.88% <ø> (+7.07%) ⬆️
compiler/core/js_packages_state.ml 80.00% <100.00%> (+3.52%) ⬆️
compiler/ext/bsc_args.ml 100.00% <100.00%> (+21.42%) ⬆️
tests/ounit_tests/ounit_tests_main.ml 100.00% <ø> (ø)
tests/ounit_tests/ounit_compile_request_tests.ml 93.44% <93.44%> (ø)
compiler/core/js_packages_info.ml 79.24% <70.58%> (+5.33%) ⬆️
compiler/bsc/rescript_compiler_driver.ml 72.53% <64.51%> (-7.47%) ⬇️
compiler/bsc/compile_request.ml 94.17% <94.17%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Why:
    bsc's flags set global compiler state as they were parsed, so the only
    way to describe a compile was a list of strings. Compile_request is that
    description as a record: of_argv reads the flags into it, to_argv
    writes them back, and apply sets the request's state from it. bsc's
    command line and a file's @@config flags go through it now; the build
    system can build the record directly in a next step (#9303).

    Each flag has a kind: Build_system, Public, Debug or Command. The
    record holds what the flags gave, so @@config is applied on top of the
    command line as before. A round-trip test reads every flag back from
    to_argv. Bsc_args keeps only the usage text and its exceptions; its
    old parser and Ext_spec are removed.

Diagnostic added (invalid flag values):
Example:
    bsc -color red -enable-experimental Unknown A.res
Before (diagnostic):
    (the values were ignored)
After (diagnostic):
    Unsupported color setting: red

Other differences, all on bsc's command line: commands such as -format
and -e run after every flag is read, not at their position; the namespace
of -bs-ns is opened before the -open modules, as the build system passes
it anyway; an invalid @@config flag applies none of the file's flags.

Part of #9303

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kbf3gHAzsdStoCEpBgx2tS
Signed-off-by: Christoph Knittel <ck@cca.io>
@pkg-pr-new

pkg-pr-new Bot commented Nov 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9306

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9306

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9306

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9306

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9306

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9306

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9306

commit: daafede

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant