Repository navigation
Conversation
ChangelogNo changelog entry. Semantic Diff1 commit · Full page Fold the outcome printer into typing and drop the startup hooksdffeec9 · cknitt + Claude · Nov 22, 2026, 07:23 UTC The type checker printed types and signatures through Oprint, four refs that failed until Res_outcome_printer.setup filled them, and called the ReScript pattern printer, the polymorphic variant printer and the polymorphic variant match compiler through refs that Bs_conditional_initial set at startup. The hooks existed because those modules sat in libraries above the type checker. Now that typing links the printer library, they can be called directly: - Res_outcome_printer moves from outcome_printer into typing, and Printtyp calls it. Oprint, Res_outcome_printer.setup and the outcome_printer library are gone. - Parmatch calls Pattern_printer, Printtyp calls Res_printer.polyvar_ident_to_string, and Matching calls Polyvar_pattern_match. Matching's unused default implementations, its as_interval and Switch.test_sequence, which only they used, are removed. - Ctype.variant_is_subtype is a function instead of a ref filled with Matching_polyfill.variant_is_subtype. Its body moves into Ctype, checking the base type with Ctype's own helpers, since Typeopt depends on Ctype; get_unboxed_type_representation moves up, unchanged, to precede it. - Bs_conditional_initial keeps the hooks that can't be direct calls (the .cmi loader and the build file store, which tests replace) and moves into typing. Output is unchanged. |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## layout-single-user-moves #9380 +/- ##
============================================================
+ Coverage 82.20% 82.22% +0.02%
============================================================
Files 463 461 -2
Lines 65771 65757 -14
============================================================
+ Hits 54066 54068 +2
+ Misses 11705 11689 -16
🚀 New features to boost your workflow:
|
✅ Compiler benchmarksAllocated wordsIn total: 636,570,609 → 636,559,570 (±0.00%). Generated projects: 629,021,426 → 629,022,510 (±0.00%). None of the 265 benchmarks changed by 0.1% or more. InstructionsIn total: 9,220,978,239 → 9,222,147,518 (+0.01%).
5 more changes
Output sizeIn total: 25,969,918 → 25,968,588 (-0.01%). None of the 13 benchmarks changed by 0.1% or more. Pull request dffeec9 compared with base 3d99a27 in this run. |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
The type checker printed types and signatures through Oprint, four refs that failed until Res_outcome_printer.setup filled them, and called the ReScript pattern printer, the polymorphic variant printer and the polymorphic variant match compiler through refs that Bs_conditional_initial set at startup. The hooks existed because those modules sat in libraries above the type checker. Now that typing links the printer library, they can be called directly: - Res_outcome_printer moves from outcome_printer into typing, and Printtyp calls it. Oprint, Res_outcome_printer.setup and the outcome_printer library are gone. - Parmatch calls Pattern_printer, Printtyp calls Res_printer.polyvar_ident_to_string, and Matching calls Polyvar_pattern_match. Matching's unused default implementations, its as_interval and Switch.test_sequence, which only they used, are removed. - Ctype.variant_is_subtype is a function instead of a ref filled with Matching_polyfill.variant_is_subtype. Its body moves into Ctype, checking the base type with Ctype's own helpers, since Typeopt depends on Ctype; get_unboxed_type_representation moves up, unchanged, to precede it. - Bs_conditional_initial keeps the hooks that can't be direct calls (the .cmi loader and the build file store, which tests replace) and moves into typing. Output is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QchYQ7itFLVLUmZ368okjH Signed-off-by: Christoph Knittel <ck@cca.io>
15d7218 to
dffeec9
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The type checker printed types and signatures through
Oprint: four refs that failed untilRes_outcome_printer.setupfilled them. It also reached three more modules through refs thatBs_conditional_initialset at startup:These hooks existed because the modules sat in libraries above the type checker. Now that
typinglinks the printer library, the type checker calls them directly:Res_outcome_printermoves fromoutcome_printerintotyping, andPrinttypcalls it.Oprint,Res_outcome_printer.setupand theoutcome_printerlibrary are gone.ParmatchcallsPattern_printer.PrinttypcallsRes_printer.polyvar_ident_to_string.MatchingcallsPolyvar_pattern_match.Matching's never-used default implementations, itsas_interval, andSwitch.test_sequence, which only those defaults used.Ctype.variant_is_subtypeis a function instead of a ref filled withMatching_polyfill.variant_is_subtype.Ctype, checking the base type withCtype's own helpers, sinceTypeoptdepends onCtype.get_unboxed_type_representationmoves up, unchanged, to precede it.Matching_polyfillis gone.Bs_conditional_initial: the hooks that can't be direct calls, the.cmiloader and the build file store, which tests replace. It moves intotyping.Output is unchanged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QchYQ7itFLVLUmZ368okjH