Repository navigation
Reclaim cancelled requests' stranded CONNECTING pool slots - #8
Merged
Jacob-Met merged 1 commit intoNov 16, 2026
Merged
Conversation
Port upstream encode#1099 into the fork's retired-connection and lazy-idle-probe lifecycle. A task cancelled after pool assignment can otherwise strand a never-started CONNECTING connection until requests permanently time out. The issue-1093 regression fails before the fix and passes after. Full suite: 272 passed, 6 inherited xpasses; packaged-wheel cold test, mypy package, and Ruff passed. Original approach and regression adapted from encode#1099 Co-authored-by: wwmanidumaneesha <manidumaneeshaww@gmail.com>
Jacob-Met
deleted the
fix/reclaim-cancelled-connecting-pool-gpt6-mwjix
branch
November 16, 2026 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visible failure
A queued HTTP/1.1 request cancelled after assignment strands a new CONNECTING connection. After enough cancellations, a healthy pool becomes permanently full and callers get PoolTimeout until restart (encode#1093).
Change
Port the already-proposed upstream fix encode#1099 to this fork, integrating its orphan cleanup with existing retired connections and lazy idle probes. Credit to upstream author wwmanidumaneesha; no duplicate upstream PR is needed.
Checks
Next
Upstream PR encode#1099 remains open. Preserve this in fork and adopt upstream once merged.