Repository navigation
Remove polyfills natively supported across the browser support matrix - #127
Open
mattcosta7 with Copilot wants to merge 4 commits into
Open
mattcosta7 with Copilot wants to merge 4 commits into
mattcosta7 with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: mattcosta7 <8616962+mattcosta7@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unnecessary browser polyfills based on Browserslist policy
Remove polyfills natively supported across the browser support matrix
Sep 14, 2026
mattcosta7
marked this pull request as ready for review
November 19, 2026 15:48
mattcosta7
requested review from
alaingoga
and
an adaptive review from Copilot
November 19, 2026 15:48
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Removing the Promise.try and iterator-helper polyfills leaves these APIs unavailable in Safari minor releases still covered by the support policy, causing regressions in supported browsers.
No open issues 🎉
What changed in this PR
This PR reduces the browser-support package’s bundle by removing polyfills considered redundant with native browser support. It retains requestIdleCallback and Invoker Commands support while leaving baseSupport detection unchanged.
Changes:
- Removes nine local polyfill implementations and their corresponding tests.
- Removes the popover polyfill dependency and trims the exported registry.
- Removes support-table rows associated with deleted registry entries.
| File | Description |
|---|---|
test/set-methods.js |
Removes Set-method polyfill tests. |
test/promise-withResolvers.js |
Removes Promise.withResolvers polyfill tests. |
test/promise-try.js |
Removes Promise.try polyfill tests. |
test/object-groupby.js |
Removes Object.groupBy polyfill tests. |
test/navigator-clipboard.js |
Removes clipboard read/write fallback tests. |
test/map-groupby.js |
Removes Map.groupBy polyfill tests. |
test/iterator-helpers.js |
Removes iterator-helper polyfill tests. |
test/element-checkvisibility.js |
Removes visibility-check polyfill tests. |
test/clipboarditem.js |
Removes ClipboardItem polyfill tests. |
src/set-methods.ts |
Deletes Set-method polyfills. |
src/promise-withResolvers.ts |
Deletes the Promise.withResolvers polyfill. |
src/promise-try.ts |
Deletes the Promise.try polyfill. |
src/object-groupby.ts |
Deletes the Object.groupBy polyfill. |
src/navigator-clipboard.ts |
Deletes clipboard read/write fallbacks. |
src/map-groupby.ts |
Deletes the Map.groupBy polyfill. |
src/iterator-helpers.ts |
Deletes iterator-helper polyfills. |
src/index.ts |
Retains only idle-callback and Invoker Commands polyfills. |
src/element-checkvisibility.ts |
Deletes the visibility-check polyfill. |
src/clipboarditem.ts |
Deletes the ClipboardItem polyfill. |
package.json |
Removes the popover polyfill dependency. |
package-lock.json |
Removes the popover dependency’s lockfile entries. |
docs/index.html |
Removes five rows for deleted registry entries. |
Review effort: Balanced (adaptive)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every polyfill in this package except
requestIdleCallbackand the Invoker Commands API is now natively available in all browsers selected by our Browserslist policy (last 10 Chrome/Edge/Firefox versions,last 3 Safari major versions,Firefox ESR). This drops ~9 modules and one dependency from the shipped bundle.src/index.tsThe registry retains only the two polyfills still doing work — Safari lacks
requestIdleCallback, and Firefox ESR / older Safari majors lackcommand/commandfor:baseSupportis intentionally unchanged: its checks are independent feature detection for the support floor, not mirrors of the polyfill registry.Deleted sources and tests
clipboarditem,element-checkvisibility,navigator-clipboard,object-groupby,map-groupby,promise-try,promise-withResolvers,iterator-helpers,set-methods— plus their counterparts intest/.Dependencies
@oddbird/popover-polyfillremoved vianpm uninstall(package.json+package-lock.json).invokers-polyfillstays.Support matrix docs
docs/index.htmlresolves each row'sdata-polyfillkey against the exported registry, so rows for now-absent keys would render as unsupported. Removed the rows forclipboardItem,elementCheckVisibility,navigatorClipboard, and bothpopoverentries.Note for reviewers
The
beforetoggle on Dialogrow referencesdata-polyfill="dialogToggleEvents", which was already missing from the registry before this change. Left as-is to keep the diff scoped — worth a follow-up.