Skip to content

Firebase: stop ignoring firebase.json - #4945

Merged
dooleydevin merged 1 commit into
github:mainfrom
NotAFlightRisk:firebase-commit-firebase-json
Nov 20, 2026
Merged

dooleydevin merged 1 commit into
github:mainfrom
NotAFlightRisk:firebase-commit-firebase-json

Conversation

@NotAFlightRisk

Copy link
Copy Markdown
Contributor

Link to the application or project's homepage

https://firebase.google.com

Reasons for making this change

With firebase.json ignored, only the machine that ran firebase init can deploy. It's the project config init writes rather than anything built, and firebase deploy from a fresh clone stops at "could not locate firebase.json" without it. Same for the GitHub Actions deploy that firebase init hosting:github sets up, since that runs on a fresh checkout.

Links to documentation supporting these rule changes

https://firebase.google.com/docs/cli#the_firebasejson_file says it's "required to deploy assets with the Firebase CLI". And when there's no .gitignore yet, firebase init writes its own from https://github.com/firebase/firebase-tools/blob/main/templates/_gitignore, which doesn't ignore it.

Merge and Approval Steps

@NotAFlightRisk
NotAFlightRisk requested a review from a team as a code owner November 20, 2026 16:19
Copilot AI adaptive review requested due to automatic review settings November 20, 2026 16:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified, and the change only removes the ignore rule preventing the required Firebase configuration from being committed while preserving the other ignore patterns.

No open issues 🎉

What changed in this PR

Updates the Firebase gitignore template so the required firebase.json project configuration can be committed and used for deployments from fresh clones and CI environments.

Changes:

  • Removes /firebase.json from the Firebase ignore rules.
  • Retains existing ignores for Firebase-generated caches, logs, emulator data, dependencies, and .firebaserc.
File Description
Firebase.gitignore Removes the ignore rule for /firebase.json while retaining the other Firebase-specific ignore patterns, including .firebaserc.

Review effort: Lite (adaptive)

@dooleydevin dooleydevin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Thank you for all of the helpful documentation!

@dooleydevin
dooleydevin merged commit 36e3c82 into github:main Nov 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants