Repository navigation
Firebase: stop ignoring firebase.json - #4945
Merged
dooleydevin merged 1 commit intoNov 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified, and the change only removes the ignore rule preventing the required Firebase configuration from being committed while preserving the other ignore patterns.
No open issues 🎉
What changed in this PR
Updates the Firebase gitignore template so the required firebase.json project configuration can be committed and used for deployments from fresh clones and CI environments.
Changes:
- Removes
/firebase.jsonfrom the Firebase ignore rules. - Retains existing ignores for Firebase-generated caches, logs, emulator data, dependencies, and
.firebaserc.
| File | Description |
|---|---|
| Firebase.gitignore | Removes the ignore rule for /firebase.json while retaining the other Firebase-specific ignore patterns, including .firebaserc. |
Review effort: Lite (adaptive)
dooleydevin
approved these changes
Nov 20, 2026
dooleydevin
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense to me! Thank you for all of the helpful documentation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the application or project's homepage
https://firebase.google.com
Reasons for making this change
With
firebase.jsonignored, only the machine that ranfirebase initcan deploy. It's the project configinitwrites rather than anything built, andfirebase deployfrom a fresh clone stops at "could not locate firebase.json" without it. Same for the GitHub Actions deploy thatfirebase init hosting:githubsets up, since that runs on a fresh checkout.Links to documentation supporting these rule changes
https://firebase.google.com/docs/cli#the_firebasejson_file says it's "required to deploy assets with the Firebase CLI". And when there's no
.gitignoreyet,firebase initwrites its own from https://github.com/firebase/firebase-tools/blob/main/templates/_gitignore, which doesn't ignore it.Merge and Approval Steps