Repository navigation
Bump basic-ftp from 5.2.2 to removed in the npm_and_yarn group across 1 directory - #131
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The change has unresolved critical issues: it upgrades the test runner to dependencies requiring Node 22 while workflows still use Node 20, and introduces transitive picomatch versions with an unpatched high-severity vulnerability.
2 open issues
What changed in this PR
This PR removes the transitive basic-ftp dependency by upgrading @web/test-runner and regenerating the npm dependency lockfile; the upgrade also introduces a Node.js 22 requirement while repository workflows still use Node.js 20.
Changes:
- Upgrades
@web/test-runnerfrom0.18.1to1.0.1. - Removes
basic-ftpand related obsolete transitive dependencies. - Refreshes the broader web testing and development dependency tree.
| File | Description |
|---|---|
| package.json | Updates the direct @web/test-runner development dependency. |
| package-lock.json | Records the upgraded dependency tree and removes basic-ftp. |
Review effort: Lite (adaptive)
|
@copilot address review comments |
Updated all build and publish workflow Node versions to 22 in |
|
@copilot updated basic-ftp to v6.2.6 instead of updating test-runner |
Updated to |
|
@dependabot recreate |
Bumps the npm_and_yarn group with 1 update in the / directory: [basic-ftp](https://github.com/patrickjuchli/basic-ftp). Removes `basic-ftp` --- updated-dependencies: - dependency-name: basic-ftp dependency-version: dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
0f00c7f to
6074019
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Bumps the npm_and_yarn group with 1 update in the / directory: basic-ftp.
Removes
basic-ftp