Repository navigation
gh-140266: Only pass _PYTHON_HOST_PLATFORM when cross compiling - #161530
Merged
kushaldas merged 2 commits intoNov 21, 2026
Merged
Conversation
configure sets _PYTHON_HOST_PLATFORM only for cross builds, but passed it to the build Python for every --with-build-python build. In a native build it was empty, so sysconfig.get_platform() returned "" and build-details.json ended up with "platform": "". Co-authored-by: Zanie Blue <contact@zanie.dev> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
itamaro
force-pushed
the
gh-140266-host-platform-cross-only
branch
from
November 7, 2026 05:03
4321c38 to
c7bf53b
Compare
itamaro
marked this pull request as ready for review
November 7, 2026 15:58
itamaro
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
November 7, 2026 15:58
superajun-wsj
added a commit
to superajun-wsj/cpython
that referenced
this pull request
Nov 20, 2026
Merge b09a7e9 while preserving the prerequisite PR python#161530 and pythongh-162308 fix commits. Resolve the checksharedmods recipe conflict by using RUNSHARED around MODULE_CHECK_COMMAND: native checks run the target interpreter and need its runtime library path. Other upstream RUNSHARED_FOR_BUILD uses remain part of the merged main. Regenerate configure with Autoconf 2.72. Validation on the updated source: - Fresh native host and target builds passed with differing _bisect configurations. The original recipe reproduced both import errors; the fixed recipe and inherited-platform check had zero import failures. - A real x86_64-to-AArch64 configure and make all build passed, with all enabled target modules passing the file checks. - test_sysconfig, test_build_details, and test_tools.test_makefile passed: 68 tests run, 8 skipped. - Updated workflow YAML, shell syntax, and diff whitespace checks passed. Co-authored-by: TRAE CLI <traecli@bytedance.com>
kushaldas
approved these changes
Nov 21, 2026
kushaldas
left a comment
Member
There was a problem hiding this comment.
This looks good. I cross-compiled AArch64 to verify build works.
kushaldas
enabled auto-merge (squash)
November 21, 2026 09:15
|
Thanks @itamaro for the PR, and @kushaldas for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-162373 is a backport of this pull request to the 3.15 branch. |
|
GH-162374 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configureonly sets_PYTHON_HOST_PLATFORMwhen cross compiling, butPYTHON_FOR_BUILDexported it whenever--with-build-pythonwas given. A native build with a build Python got_PYTHON_HOST_PLATFORM="", whichsysconfig.get_platform()returns unchanged, sobuild-details.jsonhad"platform": ""and the build directory was namedbuild/lib.-3.X.This passes the variable only when cross compiling.
Tested on macOS with
./configure --with-build-python=... && make build-details.json:platformismacosx-27.2-arm64and the build directory is named normally.Written with assistance from Claude Fable 5.1